tustvold commented on code in PR #4859:
URL: https://github.com/apache/arrow-rs/pull/4859#discussion_r1337498169
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -299,9 +301,9 @@ impl Read for ArrowColumnChunkReader {
/// A shared [`ArrowColumnChunk`]
///
-/// This allows it to be owned by [`ArrowPageWriter`] whilst allowing access
via
+/// This allows it to be owned by lower level page writers whilst allowing
access via
/// [`ArrowRowGroupWriter`] on flush, without requiring self-referential
borrows
-type SharedColumnChunk = Arc<Mutex<ArrowColumnChunk>>;
+pub type SharedColumnChunk = Arc<Mutex<ArrowColumnChunk>>;
Review Comment:
This is a bit of a hack, that I stomached largely because it was an internal
implementation detail, is there some way we can keep this hidden as an
implementation detail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
