paleolimbot commented on code in PR #37843:
URL: https://github.com/apache/arrow/pull/37843#discussion_r1338890757
##########
r/tests/testthat/test-schema.R:
##########
@@ -300,6 +300,9 @@ test_that("schema extraction", {
expect_equal(schema(example_data), tbl$schema)
expect_equal(schema(tbl), tbl$schema)
+ expect_equal(schema(data.frame(a = 1, a = "x")), schema(a = double(), a.1 =
string()))
Review Comment:
```suggestion
expect_equal(schema(data.frame(a = 1, a = "x", check.names = FALSE)),
schema(a = double(), a = string()))
```
(This might error and that's OK too, can just be `expect_error()`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
