fredrikhgrelland commented on code in PR #1118:
URL: https://github.com/apache/arrow-adbc/pull/1118#discussion_r1339080964
##########
go/adbc/driver/snowflake/statement.go:
##########
@@ -108,6 +108,11 @@ func (st *statement) SetOption(key string, val string)
error {
case adbc.OptionKeyIngestTargetTable:
st.query = ""
st.targetTable = val
+ case adbc.OptionKeyIngestTemporary:
+ return adbc.Error{
+ Msg: fmt.Sprintf("[Snowflake] Unknown statement option
'%s'", key),
+ Code: adbc.StatusNotImplemented,
+ }
Review Comment:
The default
https://github.com/apache/arrow-adbc/blob/main/go/adbc/driver/snowflake/statement.go#L145-L149
will throw `StatusInvalidArgument` while
https://github.com/apache/arrow-adbc/blob/main/python/adbc_driver_manager/adbc_driver_manager/dbapi.py#L876-L879
checks for `StatusNotImplemented`
If you do not want to change the go implementation, the python manager could
pass on ProgrammingError as well,
```
try:
self._stmt.set_options(**options)
except (NotSupportedError, ProgrammingError):
pass
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
