jorisvandenbossche commented on code in PR #37436:
URL: https://github.com/apache/arrow/pull/37436#discussion_r1339686833
##########
python/pyarrow/tests/util.py:
##########
@@ -456,4 +456,5 @@ def windows_has_tzdata():
this configurable at run-time)
"""
tzdata_path = os.path.expandvars(r"%USERPROFILE%\Downloads\tzdata")
- return os.path.exists(tzdata_path)
+ tzdata_set_path = os.environ.get('PYARROW_TZDATA_PATH', '')
+ return os.path.exists(tzdata_path) or os.path.exists(tzdata_set_path)
Review Comment:
Should we here only test `tzdata_set_path` _if set_ (so that you set the env
variable, we don't fallback to check the default location)?
##########
ci/appveyor-cpp-build.bat:
##########
@@ -132,6 +132,15 @@ set ARROW_HOME=%CONDA_PREFIX%\Library
@rem ARROW-3075; pkgconfig is broken for Parquet for now
set PARQUET_HOME=%CONDA_PREFIX%\Library
+@rem Download IANA Timezone Database to a non-standard location to
+@rem test the configurability of the timezone database path
Review Comment:
One more question here: we currently also download the database in
appveyor-cpp-setup.bat, which is typically always run before this file I would
think?
Should we then remove it there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
