wgtmac commented on code in PR #36574:
URL: https://github.com/apache/arrow/pull/36574#discussion_r1340298780
##########
cpp/src/parquet/page_index.h:
##########
@@ -283,7 +280,8 @@ class PARQUET_EXPORT ColumnIndexBuilder {
/// not write any data to the sink.
///
/// \param[out] sink output stream to write the serialized message.
- virtual void WriteTo(::arrow::io::OutputStream* sink) const = 0;
+ /// \param[in] encryptor encryptor to encrypt the serialized column index.
+ virtual void WriteTo(::arrow::io::OutputStream* sink, Encryptor* encryptor)
const = 0;
Review Comment:
It was suggested by @emkornfield in the review comments to avoid default
parameter as much as possible. However, almost all encryptors/decryptors in the
parquet-cpp are default to null. I think here I can make it default to null to
be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
