alamb commented on code in PR #7684: URL: https://github.com/apache/arrow-datafusion/pull/7684#discussion_r1340471153
########## datafusion/physical-expr/src/lib.rs: ########## @@ -28,7 +28,6 @@ pub mod equivalence; pub mod execution_props; pub mod expressions; pub mod functions; -pub mod hash_utils; Review Comment: I think this is technically a breaking change if someone used `hash_utils` directly in their code. Perhaps we could leave a pointer like ```suggestion // backwards compatibility pub use datafusion_common::hash_util; ``` But I don't think that is critical -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
