mqy commented on a change in pull request #9122:
URL: https://github.com/apache/arrow/pull/9122#discussion_r553462414



##########
File path: rust/arrow/src/array/array_struct.rs
##########
@@ -69,6 +69,9 @@ impl StructArray {
     }
 
     /// Return child array whose field name equals to column_name
+    ///
+    /// Note: The Arrow specification allows for duplicate field names, and in 
such

Review comment:
       It is not acceptable if we silently append/ignore/replace duplicate 
fields. Even if we can managed to let user to configure this `global` behavior, 
it may not satisfy all possible duplications even in a single file: some one 
want to append but another want to ignore.  So, at present before we can find 
the solution to let user define the behavior,  I suggest raising error on 
duplication.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to