tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1340525553
##########
python/pyarrow/_dataset_parquet.pyx:
##########
@@ -711,6 +889,20 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions):
cdef ArrowReaderProperties* arrow_reader_properties(self):
return self.parquet_options.arrow_reader_properties.get()
+ IF PARQUET_ENCRYPTION_ENABLED:
+ @property
+ def parquet_decryption_config(self):
Review Comment:
Thank you for your comment. Raising a NotImplementedError might not be the
optimal approach in this scenario. PARQUET_ENCRYPTION_ENABLED is a compile-time
flag that would be set intentionally, having the code throw an exception at
runtime could lead to confusion.
Users who deliberately disable the encryption feature presumably have no
intention of using the parquet encryption. Throwing an error in this case might
be seen as unexpected behavior, as users might not be attempting to use a
feature they knowingly disabled. This could lead to unnecessary troubleshooting
and frustration.
Looking forward to your thoughts on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
