R-JunmingChen commented on PR #37418: URL: https://github.com/apache/arrow/pull/37418#issuecomment-1740451608
Ok, I get the point, thank guidances from @bkietz and @pitrou. Before I implement this version, I have aquestion to discuss: Do we really need to make `DictionaryArray::CompactTransposeIndices` a member function? `DictionaryArray::Compact` seems to be adequate to be exposed to users, or we make `DictionaryArray::CompactTransposeIndices` a private member function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
