mapleFU commented on code in PR #37874:
URL: https://github.com/apache/arrow/pull/37874#discussion_r1341208665
##########
cpp/src/parquet/encoding.cc:
##########
@@ -3382,6 +3385,17 @@ class DeltaByteArrayDecoderImpl : public DecoderImpl,
virtual public TypedDecode
if (ARROW_PREDICT_FALSE(static_cast<size_t>(prefix_len_ptr[i]) >
prefix.length())) {
throw ParquetException("prefix length too large in DELTA_BYTE_ARRAY");
}
+ if (prefix_len_ptr[i] == 0) {
Review Comment:
Emmm I don't catch what you mean. When meet the case you're saying, when
handling "cccddd":
1. buffer -> point to "ddd", length = 3
2. prefix = "ccc". prefix-length = 3
So here neither case is meet. I think `prefix` doesn't means `prefix`,
actually it just means `last-value`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
