nealrichardson commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1341302408
##########
r/tools/nixlibs.R:
##########
@@ -168,17 +178,22 @@ select_binary <- function(os =
tolower(Sys.info()[["sysname"]]),
} else {
# No binary available for arch
cat(sprintf("*** Building on %s %s\n", os, arch))
- NULL
+ binary <- NULL
}
+ return(binary)
}
# This tests that curl and OpenSSL are present (bc we can include their
headers)
# and it checks for other versions/features and raises errors that we grep for
-test_for_curl_and_openssl <- "
-#include <ciso646>
+test_for_curl_and_openssl <-
+ "#include <ciso646>
+#ifndef __APPLE__
#ifdef _LIBCPP_VERSION
#error Using libc++
#endif
+#elif __GLIBCXX__
+#error Using libstdc++
Review Comment:
Did you confirm that this is necessary?
If so, I might refactor this check for readability: ifdef apple, then check
for libstdcxx, else check for libcxx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
