tustvold commented on code in PR #4884:
URL: https://github.com/apache/arrow-rs/pull/4884#discussion_r1342126976
##########
parquet/src/bin/parquet-fromcsv.rs:
##########
@@ -386,9 +386,6 @@ fn convert_csv_to_parquet(args: &Args) -> Result<(),
ParquetFromCsvError> {
Compression::BROTLI(_) => {
Box::new(brotli::Decompressor::new(input_file, 0)) as Box<dyn Read>
}
- Compression::LZ4 => Box::new(lz4::Decoder::new(input_file).map_err(|e|
{
Review Comment:
This will decode lz4 data encoded without any framing, which is so niche
that I struggle to conceive of people relying on this functionality. Further
this is a utility CLI tool, and so I'm not too concerned about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
