emkornfield commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r1342164915
##########
cpp/src/parquet/properties.h:
##########
@@ -757,6 +825,19 @@ class PARQUET_EXPORT WriterProperties {
return false;
}
+ bool bloom_filter_enabled() const {
+ // Note: We do not encourage enabling bloom filter for all columns. So
+ // default_column_properties_.bloom_filter_enabled is always false and
+ // cannot be altered by user. Thus we can safely skip checking it here.
+ return std::any_of(column_properties_.begin(), column_properties_.end(),
+ [](auto& p) { return p.second.bloom_filter_enabled();
});
Review Comment:
```suggestion
[](auto& p) { return p.second.bloom_filter_enabled();
});
```
Please spell out the type for auto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
