etseidl commented on code in PR #37940:
URL: https://github.com/apache/arrow/pull/37940#discussion_r1342891054


##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -1413,6 +1413,68 @@ TEST_F(TestLargeStringParquetIO, Basics) {
   this->RoundTripSingleColumn(large_array, large_array, arrow_properties);
 }
 
+using TestDeltaBinaryPacked32ParquetIO = TestParquetIO<::arrow::Int32Type>;
+
+TEST_F(TestDeltaBinaryPacked32ParquetIO, DeltaBinaryPacked) {

Review Comment:
   Sure. Since the tests are identical except for the typing, is it worth the 
effort to make this a typed test suite, but for just two types?
   
   Oh, I see there is one in encoding_test already. Thanks for pointing me 
there @mapleFU 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to