viirya commented on code in PR #7723:
URL: https://github.com/apache/arrow-datafusion/pull/7723#discussion_r1342925177
##########
datafusion/common/src/config.rs:
##########
@@ -453,11 +453,13 @@ config_namespace! {
/// ```
pub repartition_sorts: bool, default = true
- /// When true, DataFusion will opportunistically remove sorts by
replacing
- /// `RepartitionExec` with `SortPreservingRepartitionExec`, and
+ /// When true, DataFusion will opportunistically remove sorts when the
data is already sorted,
+ /// replacing `RepartitionExec` with `SortPreservingRepartitionExec`,
and
Review Comment:
Hmm, actually there is no `SortPreservingRepartitionExec` operator but it is
a variant of `RepartitionExec` with `preserve_order` as true. It is a little
confusion at first if trying to look for `SortPreservingRepartitionExec` type
in IDE.
Maybe:
```suggestion
/// replacing `RepartitionExec` with `SortPreservingRepartitionExec`
(i.e., `RepartitionExec` with `preserve_order` as true), and
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
