tolleybot commented on code in PR #34616: URL: https://github.com/apache/arrow/pull/34616#discussion_r1342947063
########## cpp/src/arrow/dataset/dataset_encryption_test.cc: ########## @@ -0,0 +1,216 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <string_view> + +#include "gtest/gtest.h" + +#include "arrow/api.h" +#include "arrow/dataset/api.h" +#include "arrow/dataset/parquet_encryption_config.h" +#include "arrow/dataset/partition.h" +#include "arrow/filesystem/mockfs.h" +#include "arrow/io/api.h" +#include "arrow/status.h" +#include "arrow/table.h" +#include "arrow/testing/gtest_util.h" +#include "parquet/arrow/reader.h" +#include "parquet/encryption/test_in_memory_kms.h" + +constexpr std::string_view kFooterKeyMasterKey = "0123456789012345"; +constexpr std::string_view kFooterKeyMasterKeyId = "footer_key"; +constexpr std::string_view kFooterKeyName = "footer_key"; +constexpr std::string_view kColumnMasterKey = "1234567890123450"; +constexpr std::string_view kColumnMasterKeysId = "col_key"; +constexpr std::string_view kColumnKeyMapping = "col_key: a"; +constexpr std::string_view kBaseDir = ""; + +using arrow::internal::checked_pointer_cast; + +namespace arrow { +namespace dataset { + +class DatasetEncryptionTest : public ::testing::Test { + public: + // This function creates a mock file system using the current time point, creates a + // directory with the given base directory path, and writes a dataset to it using + // provided Parquet file write options. The dataset is partitioned using a Hive + // partitioning scheme. The function also checks if the written files exist in the file + // system. + static void SetUpTestSuite() { + // Creates a mock file system using the current time point. + EXPECT_OK_AND_ASSIGN(file_system, fs::internal::MockFileSystem::Make( + std::chrono::system_clock::now(), {})); + ASSERT_OK(file_system->CreateDir(std::string(kBaseDir))); + + // Prepare table data. + auto table_schema = schema({field("a", int64()), field("b", int64()), + field("c", int64()), field("part", utf8())}); + table = TableFromJSON(table_schema, {R"([ + [ 0, 9, 1, "a" ], + [ 1, 8, 2, "b" ], + [ 2, 7, 1, "c" ], + [ 3, 6, 2, "d" ], + [ 4, 5, 1, "e" ], + [ 5, 4, 2, "f" ], + [ 6, 3, 1, "g" ], + [ 7, 2, 2, "h" ], + [ 8, 1, 1, "i" ], + [ 9, 0, 2, "j" ] + ])"}); + + // Use a Hive-style partitioning scheme. + partitioning = std::make_shared<HivePartitioning>(schema({field("part", utf8())})); + + // Prepare encryption properties. + std::unordered_map<std::string, std::string> key_map; + key_map.emplace(kColumnMasterKeysId, kColumnMasterKey); + key_map.emplace(kFooterKeyMasterKeyId, kFooterKeyMasterKey); + + crypto_factory = std::make_shared<parquet::encryption::CryptoFactory>(); + auto kms_client_factory = + std::make_shared<parquet::encryption::TestOnlyInMemoryKmsClientFactory>( + /*wrap_locally=*/true, key_map); + crypto_factory->RegisterKmsClientFactory(std::move(kms_client_factory)); + kms_connection_config = std::make_shared<parquet::encryption::KmsConnectionConfig>(); + + // Set write options with encryption configuration. + auto encryption_config = + std::make_shared<parquet::encryption::EncryptionConfiguration>( + std::string(kFooterKeyName)); + encryption_config->column_keys = kColumnKeyMapping; + auto parquet_encryption_config = std::make_shared<ParquetEncryptionConfig>(); + parquet_encryption_config->Setup(crypto_factory, kms_connection_config, + std::move(encryption_config)); + + auto file_format = std::make_shared<ParquetFileFormat>(); + auto parquet_file_write_options = + checked_pointer_cast<ParquetFileWriteOptions>(file_format->DefaultWriteOptions()); + parquet_file_write_options->parquet_encryption_config = + std::move(parquet_encryption_config); + + // Write dataset. + auto dataset = std::make_shared<InMemoryDataset>(table); + EXPECT_OK_AND_ASSIGN(auto scanner_builder, dataset->NewScan()); + EXPECT_OK_AND_ASSIGN(auto scanner, scanner_builder->Finish()); + + FileSystemDatasetWriteOptions write_options; + write_options.file_write_options = parquet_file_write_options; + write_options.filesystem = file_system; + write_options.base_dir = kBaseDir; + write_options.partitioning = partitioning; + write_options.basename_template = "part{i}.parquet"; + ASSERT_OK(FileSystemDataset::Write(write_options, std::move(scanner))); + + // Verify that the files exist + std::vector<std::string> files = {"part=a/part0.parquet", "part=b/part0.parquet", + "part=c/part0.parquet", "part=d/part0.parquet", + "part=e/part0.parquet", "part=f/part0.parquet", + "part=g/part0.parquet", "part=h/part0.parquet", + "part=i/part0.parquet", "part=j/part0.parquet"}; + for (const auto& file_path : files) { + ASSERT_OK_AND_ASSIGN(auto result, file_system->GetFileInfo(file_path)); + ASSERT_EQ(result.type(), fs::FileType::File); + } + } + + protected: + inline static std::shared_ptr<fs::FileSystem> file_system; Review Comment: I updated this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
