WillAyd commented on code in PR #1148:
URL: https://github.com/apache/arrow-adbc/pull/1148#discussion_r1343148447
##########
c/driver/postgresql/postgres_copy_reader_test.cc:
##########
@@ -136,21 +137,19 @@ TEST(PostgresCopyUtilsTest, PostgresCopyWriteBoolean) {
PostgresCopyStreamWriteTester tester;
ASSERT_EQ(tester.Init(&schema.value, &array.value), NANOARROW_OK);
- struct ArrowBuffer buffer;
- ArrowBufferInit(&buffer);
- ArrowBufferReserve(&buffer, sizeof(kTestPgCopyBoolean));
- uint8_t* cursor = buffer.data;
+ ArrowBufferInit(&buffer.value);
+ ArrowBufferReserve(&buffer.value, sizeof(kTestPgCopyBoolean));
+ uint8_t* cursor = buffer->data;
Review Comment:
Ok thanks for the ideas. I think having the writer manage internally might
be best, especially in a future where we implement chunked writes. Let me give
that a pass here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
