kevingurney commented on code in PR #37981:
URL: https://github.com/apache/arrow/pull/37981#discussion_r1343295807
##########
cpp/src/arrow/pretty_print.h:
##########
@@ -77,6 +77,9 @@ struct PrettyPrintOptions {
/// If true, display schema metadata when pretty-printing a Schema
bool show_schema_metadata = true;
+
+ /// Delimiter for separating individual elements of an Array (e.g. ",")
+ std::string array_element_delimiter = ",";
Review Comment:
Hmm, good question.
I considered using a shorter name like just `element_delimiter`, but I
included `array_` because I thought that if we end up wanting to expose more
options like the ability to specify a unique delimiter for `ChunkedArray`
elements, that it might become ambiguous. In other words, it might be helpful
to have more `array_element_delimiter` and `chunked_array_element_delimiter`.
Do you think we should still remove `array_` given this consideration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
