assignUser commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1343504727
##########
r/configure:
##########
@@ -298,6 +254,11 @@ set_pkg_vars () {
if [ "$ARROW_R_CXXFLAGS" ]; then
PKG_CFLAGS="$PKG_CFLAGS $ARROW_R_CXXFLAGS"
fi
+
+ if [ "$UNAME" = "Darwin" ] && [ $(expr `sw_vers -productVersion` : '10\.13'
) -gt 3 ]; then
Review Comment:
Is this really equivalent? I think this would match e.g. 11 or 10.15 with
atleast one char and return a truthy exit code?
> If the match succeeds and the pattern contains at least one regu-
lar expression subexpression \(...\), the string correspond-
ing to \1 is returned; otherwise the matching operator
returns the number of characters matched. If the match fails and
the pattern contains a regular expression subexpression the null
string is returned; otherwise 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
