Dandandan commented on code in PR #7721:
URL: https://github.com/apache/arrow-datafusion/pull/7721#discussion_r1343969678
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -765,7 +766,12 @@ impl DisplayAs for SortExec {
let expr: Vec<String> = self.expr.iter().map(|e|
e.to_string()).collect();
match self.fetch {
Some(fetch) => {
- write!(f, "SortExec: fetch={fetch}, expr=[{}]",
expr.join(","))
+ write!(
+ f,
+ // TODO should this say topk?
Review Comment:
I'm not sure if we would like to do this? I think there are some other
`ExecutionPlan` nodes that have the algorithm depend on one of the parameters
(for example: HashAggregate `mode`s) .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
