kevingurney commented on code in PR #37981:
URL: https://github.com/apache/arrow/pull/37981#discussion_r1344134921
##########
cpp/src/arrow/pretty_print_test.cc:
##########
@@ -200,6 +200,53 @@ TEST_F(TestPrettyPrint, PrimitiveTypeNoNewlines) {
CheckPrimitive<Int32Type, int32_t>(options, is_valid, values, expected,
false);
}
+TEST_F(TestPrettyPrint, PrimitiveTypeCustomArrayElementDelimiter) {
+ PrettyPrintOptions options{};
+ // Display array contents on one line.
+ options.skip_new_lines = true;
+ // Display maximum of 3 elements at the beginning and at the end of the array
+ options.window = 3;
Review Comment:
Great! I agree. Since it is simple enough for me to modify these tests to
not include the other options and since I think it is a good idea to keep these
tests as focused as possible, I will go ahead and remove the other options as
you originally suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
