alamb commented on code in PR #7729:
URL: https://github.com/apache/arrow-datafusion/pull/7729#discussion_r1344732638
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -1051,6 +1077,91 @@ mod tests {
});
}
+ #[test]
+ fn test_date_trunc_timezones() {
+ let cases = vec![
+ (
+ vec![
+ "2020-09-08T00:00:00Z",
Review Comment:
Given the usecase is preseving timezones, it may make sense to also check
with timezones other than `Z` (like maybe +5 or +8 🤔
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -1051,6 +1077,91 @@ mod tests {
});
}
+ #[test]
+ fn test_date_trunc_timezones() {
+ let cases = vec![
+ (
+ vec![
+ "2020-09-08T00:00:00Z",
Review Comment:
Given the usecase is preseving timezones, it may make sense to also check
with timezones other than `Z` (like maybe +5 or +8 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
