jorisvandenbossche commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1345510888


##########
python/pyarrow/parquet/core.py:
##########
@@ -329,6 +330,9 @@ def __init__(self, source, *, metadata=None, 
common_metadata=None,
                  decryption_properties=None, thrift_string_size_limit=None,
                  thrift_container_size_limit=None, filesystem=None):
 
+        if pre_buffer and not is_threading_enabled():
+            pre_buffer = False

Review Comment:
   And looking at the other occurences of the check in this file, I think all 
of those can be removed, because they either eventually pass the `pre_buffer` 
keyword to `ParquetFile` (which is handled in _parquet.pyx ParquetReader) or to 
the pyarrow.dataset ParquetFileFormat/ ParquetFragmentScanOptions, which you 
already handled in _dataset_parquet.pyx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to