zeroshade commented on code in PR #1160:
URL: https://github.com/apache/arrow-adbc/pull/1160#discussion_r1346305530
##########
go/adbc/driver/snowflake/driver.go:
##########
@@ -67,6 +67,13 @@ const (
// "300ms", "1.5s" or "1m30s". ParseDuration accepts negative values
// but the absolute value will be used.
OptionClientTimeout = "adbc.snowflake.sql.client_option.client_timeout"
+ // OptionUseHighPrecision controls the data type used for NUMBER columns
+ // using a FIXED size data type. By default, this is enabled and NUMBER
+ // columns will be returned as Decimal128 types using the indicated
+ // precision and scale of the type. If disabled, then fixed-point data
+ // with a scale of 0 will be returned as Int64 columns, and a non-zero
+ // scale will return a Float64 column.
+ OptionUseHighPrecision =
"adbc.snowflake.sql.client_option.use_high_precision"
Review Comment:
added, also updated the docs in general with the new option.
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -65,6 +65,8 @@ func (s *SnowflakeQuirks) DatabaseOptions() map[string]string
{
return map[string]string{
adbc.OptionKeyURI: s.dsn,
driver.OptionSchema: s.schemaName,
+ // use int64 not decimal128 for the tests
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
