carols10cents commented on PR #4876: URL: https://github.com/apache/arrow-rs/pull/4876#issuecomment-1747528081
> I think I might be missing some context on why the pre-signed URL functionality needs to be conflated with the ObjectStore trait. TL;DR IOx; I'm happy to make changes to IOx to do whatever. That's purely due to the current IOx implementation that has a `clap_blocks` function for configuring any object store and currently returns an `Arc<DynObjectStore>`, thus erasing any type information after that point. For the bulk import functionality, what we've planned for a piece of it is a gRPC service implemented in the router that has an action that returns a pre-signed URL. Currently, the router uses the aforementioned `clap_blocks` to configure the object store and has the `Arc<DynObjectStore>` plumbed through it everywhere-- I'd like to avoid changing all that if possible, and supporting presigned URLs through other object stores if those implementations gain the signing capability in the future... does that make more sense? I am relying on the IOx context you have, let me know if I glossed over too much :) > I would have perhaps expected a `dyn Signer` that could be passed around to the places that need it. Right, but who defines `trait Signer`? I think it'd be nice if it was in `object_store` such that as more object store implementations gain that functionality, users wouldn't have to add the implementations themselves. Would that be ok or do you think it doesn't belong here? ---- Do you have any general comments about this PR as-is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
