jayzhan211 commented on issue #6981: URL: https://github.com/apache/arrow-datafusion/issues/6981#issuecomment-1748829040
> I started doing some work on this @izveigor but I am stucked in handling the non trivial case: > > [`main...edmondop:arrow-datafusion:issue-6981?`#diff-48cc9cf1bf](https://github.com/apache/arrow-datafusion/compare/main...edmondop:arrow-datafusion:issue-6981?#diff-48cc9cf1bfdb0214a9f625b384d1c4fd5967a9da61e8f22a5dc1c4c5800563b4R1511) > > I have the following newbie questions: > > * Which types I need to match against ? `(data_type, data_type)` ? > * Should I implement a deduplication post a `concat_internal` or should I find a way to rewrite `concat_internal` that minimize allocations and keep a set to avoid adding element twice? > * What when the type is not `DataType::List` ? I think union with Null is not defined, so you could just match the List type. > Should I implement a deduplication post a concat_internal or should I find a way to rewrite concat_internal that minimize allocations and keep a set to avoid adding element twice? It sounds the latter is better, but if you fails to find the way, first approach is also fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
