bkietz commented on PR #38027: URL: https://github.com/apache/arrow/pull/38027#issuecomment-1748884899
I think it'd be better to avoid tying this to the concrete Array classes. The span would expose values masked by null bits which could lead to unfortunate surprises. FWIW these classes already expose `begin, end, operator[]` yields std::optional for usability. I think it'd be more useful to expose such a helper at the buffer or array data level, for example as - `Buffer::span` analogous to `Buffer::data_as` - `ArraySpan::GetSpan` analogous to `ArraySpan::GetValues` (along with equivalents for mutable buffers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
