R-JunmingChen commented on PR #37418: URL: https://github.com/apache/arrow/pull/37418#issuecomment-1748924745
Besides, after implementing this version, here are some disvantages I think need to be discussed: 1. Performance The running of the Function version can be ended in advance. To be specific, the dictionary array which is compacted can be directly returned after checking. However, the Member Function version still need to construct a transpose map and call `Transpose`. 2.Dependency Both version we need to call `Take`. But I am not sure whether it's good for `dict_array.cc` to include `arrow/compute/api.h`, since the compilation of `compute` is optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
