spenczar commented on PR #37319: URL: https://github.com/apache/arrow/pull/37319#issuecomment-1749502887
I don't think it's reasonable to say that undocumented side effects of `combine_chunks` (from a separate function it happens to call!) are part of its API. That just implies too much surface area for the entire Arrow project and makes improvement too hard. Perhaps for optimization, explicitness is more important than implicitness, and users should call `concat_arrays` upon the chunks if they want concat's side effects to occur. Alternatively, we could have a new method (`ChunkedArray.to_array()` perhaps) which returns a single array but makes no promises about copying. The current thing doesn't make any promises either, but a new method would certainly be API-compatible. I think it would be difficult to write the API docs to explain the distinction between that new method and to_array. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
