davidhcoe commented on code in PR #37731:
URL: https://github.com/apache/arrow/pull/37731#discussion_r1349176422
##########
csharp/src/Apache.Arrow/DecimalUtility.cs:
##########
@@ -52,7 +52,11 @@ internal static decimal GetDecimal(in ArrowBuffer
valueBuffer, int index, int sc
BigInteger integerPart = BigInteger.DivRem(integerValue,
scaleBy, out BigInteger fractionalPart);
if (integerPart > _maxDecimal || integerPart < _minDecimal) //
decimal overflow, not much we can do here - C# needs a BigDecimal
{
- throw new OverflowException($"Value: {integerPart} too big
or too small to be represented as a decimal");
+ throw new OverflowException($"Value: {integerValue} is too
big or too small to be represented as a decimal");
+ }
+ if (fractionalPart > _maxDecimal || fractionalPart <
_minDecimal) // decimal overflow, not much we can do here - C# needs a
BigDecimal
+ {
+ throw new OverflowException($"Value: {integerValue} is too
big or too small to be represented as a decimal");
Review Comment:
updated in latest push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
