xhochy commented on a change in pull request #9140:
URL: https://github.com/apache/arrow/pull/9140#discussion_r554190275
##########
File path: dev/archery/archery/benchmark/core.py
##########
@@ -27,12 +27,13 @@ def median(values):
class Benchmark:
- def __init__(self, name, unit, less_is_better, values, stats=None):
+ def __init__(self, name, unit, less_is_better, values, counters={}):
Review comment:
```suggestion
def __init__(self, name, unit, less_is_better, values, counters=None):
```
##########
File path: dev/archery/archery/benchmark/core.py
##########
@@ -27,12 +27,13 @@ def median(values):
class Benchmark:
- def __init__(self, name, unit, less_is_better, values, stats=None):
+ def __init__(self, name, unit, less_is_better, values, counters={}):
self.name = name
self.unit = unit
self.less_is_better = less_is_better
self.values = sorted(values)
self.median = median(self.values)
+ self.counters = counters
Review comment:
```suggestion
self.counters = counters or {}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
