llama90 opened a new pull request, #38147:
URL: https://github.com/apache/arrow/pull/38147
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
* #37729
According to this issue, it has been identified that incorrect matching
results are being produced when performing an Inner Join. I took an interest in
this issue and proceeded with debugging, during which I discovered that
incorrect hash values are being generated when executing the BloomFilter
operation.
* #38074
Essentially, when executing the `HashBatch` function, data for the minibatch
size is retrieved through the `Slice` function. However, I found that within
the `Slice` function, offset calculation is performed as `uint32_t`, regardless
of the type value. Consequently, I have modified this to process the value
according to its type.
The error likely wouldn't have occurred if users had configured the column
with values corresponding to uint32_t. (I have actually tested this aspect as
well.)
### What changes are included in this PR?
I have modified the `Slice` function to reflect the type size.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
I have added unit tests and also ran the full test suite.
* TEST(KeyColumnArray, SliceBinary)
* TEST(KeyColumnArray, SliceLargeBinary)
I also wrote test code for Inner Join, but did not include it, as it was not
directly related to the bug (If you think adding those tests is beneficial,
please let me know. Personally, I considered it an unnecessary load on the unit
tests).
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
### Are there any user-facing changes?
Acero might not have a large user base as it is an experimental feature, but
I deemed the issue of incorrect join results as critical and have addressed the
bug.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
