jorisvandenbossche commented on code in PR #36846:
URL: https://github.com/apache/arrow/pull/36846#discussion_r1350039458
##########
python/pyarrow/table.pxi:
##########
@@ -5078,11 +5082,24 @@ def concat_tables(tables, c_bool promote=False,
MemoryPool memory_pool=None):
CConcatenateTablesOptions options = (
CConcatenateTablesOptions.Defaults())
+ if "promote" in kwargs:
+ warnings.warn(
+ "promote has been superseded by mode='default'.", FutureWarning)
+ if kwargs['promote'] is True:
+ promote_options = "permissive"
Review Comment:
Yeah, I mentioned that I would find a `promote=True` a better default, but
now that we deprecated it in favor of `promote_options`, we don't need to
change the current behaviour, as it will be removed anyway. And users can now
replace it with `promote_options="permissive"` if they prefer that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
