tustvold commented on code in PR #4902:
URL: https://github.com/apache/arrow-rs/pull/4902#discussion_r1350130538
##########
arrow-schema/src/field.rs:
##########
@@ -494,7 +497,9 @@ impl Field {
| DataType::LargeUtf8
| DataType::Decimal128(_, _)
| DataType::Decimal256(_, _) => {
- if self.data_type != from.data_type {
+ if from.data_type == DataType::Null {
Review Comment:
I'm not sure about this change as a NullArray is a physically distinct type
and is therefore not inherently compatible with any other types. It can be
coerced to the same type, via the cast kernels, but it is not inherently
compatible which is the notion encoded in this method.
Perhaps
https://docs.rs/arrow-cast/latest/arrow_cast/cast/fn.can_cast_types.html can
meet your requirements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
