thisisnic commented on code in PR #37961:
URL: https://github.com/apache/arrow/pull/37961#discussion_r1350198070


##########
r/R/install-arrow.R:
##########
@@ -79,7 +80,8 @@ install_arrow <- function(nightly = FALSE,
     # On the M1, we can't use the usual autobrew, which pulls Intel 
dependencies
     apple_m1 <- grepl("arm-apple|aarch64.*darwin", R.Version()$platform)
     # On Rosetta, we have to build without JEMALLOC, so we also can't autobrew
-    if (on_rosetta()) {
+    rosetta <- identical(sysname, "darwin") && identical(system("sysctl -n 
sysctl.proc_translated", intern = TRUE), "1")
+    if (rosetta) {

Review Comment:
   @assignUser It's here: 
https://arrow.apache.org/docs/r/articles/install.html?q=install_arrow#using-install_arrow
   
   > Although this function is part of the arrow package, it is also available 
as a standalone script, so you can access it without first installing the 
package:
   
   In the case of "You want to install a development build", folks may not 
already have arrow installed.  
   
   On a different note, there have been other PRs in this area of the codebase 
merged recently, so this PR may need a rebase to see how the changes affect it, 
and what needs doing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to