wgtmac commented on issue #36882:
URL: https://github.com/apache/arrow/issues/36882#issuecomment-1753243936

   > How about:
   > 
   > ```diff
   > diff --git a/cpp/src/parquet/column_writer.cc 
b/cpp/src/parquet/column_writer.cc
   > index be1881d00..88829ef5d 100644
   > --- a/cpp/src/parquet/column_writer.cc
   > +++ b/cpp/src/parquet/column_writer.cc
   > @@ -2336,7 +2336,8 @@ std::shared_ptr<ColumnWriter> 
ColumnWriter::Make(ColumnChunkMetaDataBuilder* met
   >    Encoding::type encoding = properties->encoding(descr->path());
   >    if (encoding == Encoding::UNKNOWN) {
   >      encoding = (descr->physical_type() == Type::BOOLEAN &&
   > -                properties->version() != ParquetVersion::PARQUET_1_0)
   > +                properties->version() != ParquetVersion::PARQUET_1_0 &&
   > +                properties->data_page_version() == 
ParquetDataPageVersion::V2)
   > :
   > ```
   
   This is one option, but still differs from arrow-rs, right? It also requires 
some additional work in the unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to