davidhcoe commented on PR #38154: URL: https://github.com/apache/arrow/pull/38154#issuecomment-1753859057
It is in addition to that. That was done last week and this was missed. From: Curt Hagenlocher ***@***.***> Sent: Monday, October 9, 2023 4:53 PM To: apache/arrow ***@***.***> Cc: David Coe ***@***.***>; Author ***@***.***> Subject: Re: [apache/arrow] [C#] expose ArrayDataConcatenator.Concatenate (PR #38154) @CurtHagenlocher commented on this pull request. ________________________________ In csharp/src/Apache.Arrow/Arrays/ArrayDataConcatenator.cs<https://github.com/apache/arrow/pull/38154#discussion_r1350778645>: > { - internal static ArrayData Concatenate(IReadOnlyList<ArrayData> arrayDataList, MemoryAllocator allocator = default) + public static ArrayData Concatenate(IReadOnlyList<ArrayData> arrayDataList, MemoryAllocator allocator = default) Why this instead of (or "and not also") ArrowArrayConcatenator.Concatenate? - Reply to this email directly, view it on GitHub<https://github.com/apache/arrow/pull/38154#pullrequestreview-1665271486>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADFTVNO7BMAUT7WAHL46PWTX6RP4JAVCNFSM6AAAAAA5Y3WY26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRVGI3TCNBYGY>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
