alamb commented on code in PR #7774:
URL: https://github.com/apache/arrow-datafusion/pull/7774#discussion_r1350801847
##########
.github/workflows/rust.yml:
##########
@@ -505,12 +505,8 @@ jobs:
- name: Check Cargo.toml formatting
run: |
- # if you encounter error, try rerun the command below, finally run
'git diff' to
- # check which Cargo.toml introduces formatting violation
- #
# ignore ./Cargo.toml because putting workspaces in multi-line lists
make it easy to read
Review Comment:
Can you please leave comments here about how to fix the issue if the CI
fails when someone didn't run rust_fmt_toml correctly?
When I purposely added a problem to `Cargo.toml` I got an error that I would
find hard to interpret
```shell
alamb@MacBook-Pro-8:~/Software/arrow-datafusion2$ if
`./ci/scripts/rust_toml_fmt.sh`; then echo "pass" ; else echo "failed"; fi
....
+ cargo tomlfmt -d -p ./datafusion/sqllogictest/Cargo.toml
WARN 2023-10-09T21:27:06Z: cargo_tomlfmt: dryrun founds problems in
Cargo.toml
WARN 2023-10-09T21:27:06Z: cargo_tomlfmt: exit with -1
failed
```
##########
.github/workflows/rust.yml:
##########
@@ -505,12 +505,8 @@ jobs:
- name: Check Cargo.toml formatting
run: |
- # if you encounter error, try rerun the command below, finally run
'git diff' to
- # check which Cargo.toml introduces formatting violation
- #
# ignore ./Cargo.toml because putting workspaces in multi-line lists
make it easy to read
Review Comment:
I think the reason CI originally ran`rust_fmt_toml.sh` + `git diff
--exit-code` was so that people could run `rust_fmt_toml.sh` locally and check
in the result to fix CI. Perhaps we can restore that behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
