wgtmac commented on code in PR #38163:
URL: https://github.com/apache/arrow/pull/38163#discussion_r1351131869
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2336,7 +2336,8 @@ std::shared_ptr<ColumnWriter>
ColumnWriter::Make(ColumnChunkMetaDataBuilder* met
Encoding::type encoding = properties->encoding(descr->path());
if (encoding == Encoding::UNKNOWN) {
encoding = (descr->physical_type() == Type::BOOLEAN &&
- properties->version() != ParquetVersion::PARQUET_1_0)
+ properties->version() != ParquetVersion::PARQUET_1_0 &&
+ properties->data_page_version() == ParquetDataPageVersion::V2)
Review Comment:
IIUC, if the data page version is v2, it is user's responsibility to set
parquet version to PARQUET_2_X. Unfortunately, this is not enforced yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
