zeroshade commented on code in PR #37468:
URL: https://github.com/apache/arrow/pull/37468#discussion_r1351216285
##########
go/arrow/array/concat.go:
##########
@@ -398,9 +404,14 @@ func putListViewOffsets64(in arrow.ArrayData, displacement
int64, out *memory.Bu
dstOffsets := arrow.Int64Traits.CastFromBytes(out.Bytes())
for i, offset := range srcOffsets {
- debug.Assert(!isValidAndNonEmpty(i) || offset+displacement >= 0,
- "putListViewOffsets64: offset underflow while
concatenating arrays")
- dstOffsets[outOff+i] = offset + displacement
+ if isValidAndNonEmpty(i) {
+ // This is guaranteed by RangeOfValuesUsed returning
the smallest offset
+ // of valid and non-empty list-views.
+ debug.Assert(offset+displacement >= 0,
"putListViewOffsets32: offset underflow while concatenating arrays")
Review Comment:
`putListViewOffsets64` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
