pitrou commented on code in PR #37901: URL: https://github.com/apache/arrow/pull/37901#discussion_r1351971513
########## python/requirements-wheel-test.txt: ########## @@ -7,18 +7,23 @@ pytz tzdata; sys_platform == 'win32' numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11" -numpy==1.23.4; platform_system == "Linux" and platform_machine == "aarch64" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Linux" and platform_machine == "aarch64" and python_version == "3.11" +numpy==1.26.0; platform_system == "Linux" and platform_machine == "aarch64" and python_version >= "3.12" numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9" numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11" -numpy==1.23.4; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Linux" and platform_machine != "aarch64" and python_version == "3.11" +numpy==1.26.0; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.11" numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11" -numpy==1.23.4; platform_system == "Darwin" and platform_machine == "arm64" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Darwin" and platform_machine == "arm64" and python_version == "3.11" +numpy==1.26.0; platform_system == "Darwin" and platform_machine == "arm64" and python_version >= "3.12" numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9" numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11" -numpy==1.23.4; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Darwin" and platform_machine != "arm64" and python_version == "3.11" +numpy==1.26.0; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.12" numpy==1.19.5; platform_system == "Windows" and python_version < "3.9" numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11" -numpy==1.23.4; platform_system == "Windows" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Windows" and python_version == "3.11" +numpy==1.26.0; platform_system == "Windows" and python_version >= "3.12" Review Comment: Why are you we differentiating by platform for Python 3.11 and 3.12? It looks like this could be simplified. ########## python/requirements-wheel-test.txt: ########## @@ -7,18 +7,23 @@ pytz tzdata; sys_platform == 'win32' numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11" -numpy==1.23.4; platform_system == "Linux" and platform_machine == "aarch64" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Linux" and platform_machine == "aarch64" and python_version == "3.11" +numpy==1.26.0; platform_system == "Linux" and platform_machine == "aarch64" and python_version >= "3.12" numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9" numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11" -numpy==1.23.4; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Linux" and platform_machine != "aarch64" and python_version == "3.11" +numpy==1.26.0; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.11" numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11" -numpy==1.23.4; platform_system == "Darwin" and platform_machine == "arm64" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Darwin" and platform_machine == "arm64" and python_version == "3.11" +numpy==1.26.0; platform_system == "Darwin" and platform_machine == "arm64" and python_version >= "3.12" numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9" numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11" -numpy==1.23.4; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Darwin" and platform_machine != "arm64" and python_version == "3.11" +numpy==1.26.0; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.12" numpy==1.19.5; platform_system == "Windows" and python_version < "3.9" numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11" -numpy==1.23.4; platform_system == "Windows" and python_version >= "3.11" +numpy==1.23.4; platform_system == "Windows" and python_version == "3.11" +numpy==1.26.0; platform_system == "Windows" and python_version >= "3.12" Review Comment: Why are we differentiating by platform for Python 3.11 and 3.12? It looks like this could be simplified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
