tustvold commented on code in PR #4915:
URL: https://github.com/apache/arrow-rs/pull/4915#discussion_r1352590468
##########
object_store/src/client/retry.rs:
##########
@@ -238,16 +242,14 @@ impl RetryExt for reqwest::RequestBuilder {
|| now.elapsed() > retry_timeout
|| !do_retry {
- return Err(Error{
+ return Err(Error::Response {
retries,
- message: "request error".to_string(),
- status: e.status(),
- source: Some(e),
+ source: e,
})
}
let sleep = backoff.next();
retries += 1;
- info!("Encountered request error ({}) backing off for
{} seconds, retry {} of {}", e, sleep.as_secs_f32(), retries, max_retries);
+ info!("Encountered transport error ({}) backing off
for {} seconds, retry {} of {}", e, sleep.as_secs_f32(), retries, max_retries);
Review Comment:
I wasn't really sure what to call this, but this variant is for if the
underlying connection/stream gets aborted without a response being received, so
I went with transport to describe this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
