pitrou commented on code in PR #37792: URL: https://github.com/apache/arrow/pull/37792#discussion_r1352730864
########## cpp/src/arrow/type_traits.h: ########## @@ -639,10 +681,9 @@ template <typename T, typename R = void> using enable_if_fixed_width_type = enable_if_t<is_fixed_width_type<T>::value, R>; template <typename T> -using is_binary_like_type = - std::integral_constant<bool, (is_base_binary_type<T>::value && - !is_string_like_type<T>::value) || - is_fixed_size_binary_type<T>::value>; +using is_binary_like_type = std::integral_constant< + bool, (is_base_binary_type<T>::value && !is_string_like_type<T>::value) || + is_binary_view_type<T>::value || is_fixed_size_binary_type<T>::value>; Review Comment: I agree with @felipecrv btw. This may silently produce incorrect binary-view handling in operations not touched by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
