Weijun-H commented on code in PR #7777:
URL: https://github.com/apache/arrow-datafusion/pull/7777#discussion_r1352756273
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1251,10 +1251,11 @@ impl DefaultPhysicalPlanner {
"Unsupported logical plan: Prepare"
)
}
- LogicalPlan::Dml(_) => {
+ LogicalPlan::Dml(dml) => {
// DataFusion is a read-only query engine, but also a
library, so consumers may implement this
+ let op = dml.op;
not_impl_err!(
- "Unsupported logical plan: Dml"
+ "Unsupported logical plan: Dml({op})"
Review Comment:
```suggestion
"Unsupported logical plan: Dml({0})", dml.op
```
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1251,10 +1251,11 @@ impl DefaultPhysicalPlanner {
"Unsupported logical plan: Prepare"
)
}
- LogicalPlan::Dml(_) => {
+ LogicalPlan::Dml(dml) => {
// DataFusion is a read-only query engine, but also a
library, so consumers may implement this
+ let op = dml.op;
Review Comment:
```suggestion
```
##########
datafusion/expr/src/logical_plan/dml.rs:
##########
@@ -105,7 +105,7 @@ impl DmlStatement {
}
}
-#[derive(Clone, PartialEq, Eq, Hash)]
+#[derive(Copy, Clone, PartialEq, Eq, Hash)]
Review Comment:
```suggestion
#[derive(Clone, PartialEq, Eq, Hash)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
