alamb commented on code in PR #4909:
URL: https://github.com/apache/arrow-rs/pull/4909#discussion_r1353109105
##########
arrow-csv/src/writer.rs:
##########
@@ -97,26 +92,14 @@ pub struct Writer<W: Write> {
/// Is the beginning-of-writer
beginning: bool,
/// The value to represent null entries
Review Comment:
```suggestion
/// The value to represent null entries. If not specified,
[`DEFAULT_NULL_VALUE`] is used
```
##########
arrow/tests/csv.rs:
##########
@@ -53,48 +53,6 @@ fn test_export_csv_timestamps() {
}
drop(writer);
- let left = "c1,c2
Review Comment:
Why was this test removed?
I see the output is identical in the two cases -- is there still coverage
showing that `
```
arrow_csv::WriterBuilder::new()
.with_rfc3339()
```
Produces the default values?
Perhaps given` .with_rfc3339()` is the default, maybe it should should be
deprecated too 🤔 ?
##########
arrow/tests/csv.rs:
##########
@@ -53,48 +53,6 @@ fn test_export_csv_timestamps() {
}
drop(writer);
- let left = "c1,c2
Review Comment:
Why was this test removed?
I see the output is identical in the two cases -- is there still coverage
showing that `
```
arrow_csv::WriterBuilder::new()
.with_rfc3339()
```
Produces the default values?
Perhaps given` .with_rfc3339()` is the default, maybe it should should be
deprecated too 🤔 ?
##########
arrow-csv/src/writer.rs:
##########
@@ -97,26 +92,14 @@ pub struct Writer<W: Write> {
/// Is the beginning-of-writer
beginning: bool,
/// The value to represent null entries
Review Comment:
It might help to add information about the default values for the formats
above as well
##########
arrow-csv/src/writer.rs:
##########
@@ -207,9 +190,9 @@ impl<W: Write> RecordBatchWriter for Writer<W> {
#[derive(Clone, Debug)]
pub struct WriterBuilder {
/// Optional column delimiter. Defaults to `b','`
- delimiter: Option<u8>,
+ delimiter: u8,
Review Comment:
is the idea that a `u8` is more space efficient than `Option<u8>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
