paleolimbot commented on code in PR #1189: URL: https://github.com/apache/arrow-adbc/pull/1189#discussion_r1353811809
########## c/driver/postgresql/postgresql_benchmark.cc: ########## @@ -0,0 +1,171 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + +#include <benchmark/benchmark.h> +#include <nanoarrow/nanoarrow.hpp> + +#include "adbc.h" +#include "validation/adbc_validation_util.h" + +static void BM_PostgresqlExecute(benchmark::State& state) { + const char* uri = std::getenv("ADBC_POSTGRESQL_TEST_URI"); + if (!uri) { + state.SkipWithError("ADBC_POSTGRESQL_TEST_URI not set!"); + } + adbc_validation::Handle<struct AdbcDatabase> database; + struct AdbcError error; + + if (AdbcDatabaseNew(&database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("AdbcDatabaseNew call failed"); + } + + if (AdbcDatabaseSetOption(&database.value, "uri", uri, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not set database uri option"); + } + + if (AdbcDatabaseInit(&database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("AdbcDatabaseInit failed"); + } + + adbc_validation::Handle<struct AdbcConnection> connection; + if (AdbcConnectionNew(&connection.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create connection object"); + } + + if (AdbcConnectionInit(&connection.value, &database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not connect to database"); + } + + adbc_validation::Handle<struct AdbcStatement> statement; + if (AdbcStatementNew(&connection.value, &statement.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create statement object"); + } + + const char* drop_query = "DROP TABLE IF EXISTS adbc_postgresql_ingest_benchmark"; + if (AdbcStatementSetSqlQuery(&statement.value, drop_query, &error) + != ADBC_STATUS_OK) { + state.SkipWithError("Could not set DROP TABLE SQL query"); + } + + if (AdbcStatementExecuteQuery(&statement.value, nullptr, nullptr, &error) + != ADBC_STATUS_OK) { + state.SkipWithError("Could not execute DROP TABLE SQL query"); + } + + adbc_validation::Handle<struct ArrowSchema> schema; + adbc_validation::Handle<struct ArrowArray> array; + struct ArrowError na_error; + + if (adbc_validation::MakeSchema(&schema.value, { + {"bools", NANOARROW_TYPE_BOOL}, + {"int16s", NANOARROW_TYPE_INT16}, + {"int32s", NANOARROW_TYPE_INT32}, + {"int64s", NANOARROW_TYPE_INT64}, + {"floats", NANOARROW_TYPE_FLOAT}, + {"doubles", NANOARROW_TYPE_DOUBLE}, + }) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create benchmark schema"); + } + + if (ArrowArrayInitFromSchema(&array.value, &schema.value, &na_error) != NANOARROW_OK) { + state.SkipWithError("Could not init array from schema"); + } + + if (ArrowArrayStartAppending(&array.value) != NANOARROW_OK) { + state.SkipWithError("Could not start appending to array"); + } + + // TODO: how should we construct this? + for (size_t i = 0; i < array.value.n_children; i++) { Review Comment: I think what you have here may be as simple as it gets, but if you write it as a separate function you can use `NANOARROW_RETURN_NOT_OK()` which will look (possibly) a bit nicer. ```c int make_test_array(struct ArrowArray* array, struct ArrowSchema* schema) { NANOARROW_RETURN_NOT_OK(ArrowArrayInitFromSchema(array, schema, nullptr)); // ... return NANOARROW_OK } ``` ########## c/driver/postgresql/postgresql_benchmark.cc: ########## @@ -0,0 +1,171 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + +#include <benchmark/benchmark.h> +#include <nanoarrow/nanoarrow.hpp> + +#include "adbc.h" +#include "validation/adbc_validation_util.h" + +static void BM_PostgresqlExecute(benchmark::State& state) { + const char* uri = std::getenv("ADBC_POSTGRESQL_TEST_URI"); + if (!uri) { + state.SkipWithError("ADBC_POSTGRESQL_TEST_URI not set!"); + } + adbc_validation::Handle<struct AdbcDatabase> database; + struct AdbcError error; + + if (AdbcDatabaseNew(&database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("AdbcDatabaseNew call failed"); + } + + if (AdbcDatabaseSetOption(&database.value, "uri", uri, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not set database uri option"); + } + + if (AdbcDatabaseInit(&database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("AdbcDatabaseInit failed"); + } + + adbc_validation::Handle<struct AdbcConnection> connection; + if (AdbcConnectionNew(&connection.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create connection object"); + } + + if (AdbcConnectionInit(&connection.value, &database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not connect to database"); + } + + adbc_validation::Handle<struct AdbcStatement> statement; + if (AdbcStatementNew(&connection.value, &statement.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create statement object"); + } + + const char* drop_query = "DROP TABLE IF EXISTS adbc_postgresql_ingest_benchmark"; + if (AdbcStatementSetSqlQuery(&statement.value, drop_query, &error) + != ADBC_STATUS_OK) { + state.SkipWithError("Could not set DROP TABLE SQL query"); + } + + if (AdbcStatementExecuteQuery(&statement.value, nullptr, nullptr, &error) + != ADBC_STATUS_OK) { + state.SkipWithError("Could not execute DROP TABLE SQL query"); + } + + adbc_validation::Handle<struct ArrowSchema> schema; + adbc_validation::Handle<struct ArrowArray> array; + struct ArrowError na_error; + + if (adbc_validation::MakeSchema(&schema.value, { + {"bools", NANOARROW_TYPE_BOOL}, + {"int16s", NANOARROW_TYPE_INT16}, + {"int32s", NANOARROW_TYPE_INT32}, + {"int64s", NANOARROW_TYPE_INT64}, + {"floats", NANOARROW_TYPE_FLOAT}, + {"doubles", NANOARROW_TYPE_DOUBLE}, + }) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create benchmark schema"); + } + + if (ArrowArrayInitFromSchema(&array.value, &schema.value, &na_error) != NANOARROW_OK) { + state.SkipWithError("Could not init array from schema"); + } + + if (ArrowArrayStartAppending(&array.value) != NANOARROW_OK) { + state.SkipWithError("Could not start appending to array"); + } + + // TODO: how should we construct this? + for (size_t i = 0; i < array.value.n_children; i++) { + // assumes fixed size primitive layouts for now + struct ArrowBuffer* buffer = ArrowArrayBuffer(array.value.children[i], 1); + if (ArrowBufferAppendFill(buffer, 0, 10000) != NANOARROW_OK) { + state.SkipWithError("Could not append to array"); + } + if (ArrowBufferAppendFill(buffer, 1, 10000) != NANOARROW_OK) { Review Comment: I wonder if you might need a more realistic (random?) distribution of values to get a realistic benchmark? (I don't know much about writing good C/C++ benchmarks) ########## c/driver/postgresql/postgresql_benchmark.cc: ########## @@ -0,0 +1,171 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + +#include <benchmark/benchmark.h> +#include <nanoarrow/nanoarrow.hpp> + +#include "adbc.h" +#include "validation/adbc_validation_util.h" + +static void BM_PostgresqlExecute(benchmark::State& state) { + const char* uri = std::getenv("ADBC_POSTGRESQL_TEST_URI"); + if (!uri) { + state.SkipWithError("ADBC_POSTGRESQL_TEST_URI not set!"); + } + adbc_validation::Handle<struct AdbcDatabase> database; + struct AdbcError error; + + if (AdbcDatabaseNew(&database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("AdbcDatabaseNew call failed"); + } + + if (AdbcDatabaseSetOption(&database.value, "uri", uri, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not set database uri option"); + } + + if (AdbcDatabaseInit(&database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("AdbcDatabaseInit failed"); + } + + adbc_validation::Handle<struct AdbcConnection> connection; + if (AdbcConnectionNew(&connection.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create connection object"); + } + + if (AdbcConnectionInit(&connection.value, &database.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not connect to database"); + } + + adbc_validation::Handle<struct AdbcStatement> statement; + if (AdbcStatementNew(&connection.value, &statement.value, &error) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create statement object"); + } + + const char* drop_query = "DROP TABLE IF EXISTS adbc_postgresql_ingest_benchmark"; + if (AdbcStatementSetSqlQuery(&statement.value, drop_query, &error) + != ADBC_STATUS_OK) { + state.SkipWithError("Could not set DROP TABLE SQL query"); + } + + if (AdbcStatementExecuteQuery(&statement.value, nullptr, nullptr, &error) + != ADBC_STATUS_OK) { + state.SkipWithError("Could not execute DROP TABLE SQL query"); + } + + adbc_validation::Handle<struct ArrowSchema> schema; + adbc_validation::Handle<struct ArrowArray> array; + struct ArrowError na_error; + + if (adbc_validation::MakeSchema(&schema.value, { + {"bools", NANOARROW_TYPE_BOOL}, + {"int16s", NANOARROW_TYPE_INT16}, + {"int32s", NANOARROW_TYPE_INT32}, + {"int64s", NANOARROW_TYPE_INT64}, + {"floats", NANOARROW_TYPE_FLOAT}, + {"doubles", NANOARROW_TYPE_DOUBLE}, + }) != ADBC_STATUS_OK) { + state.SkipWithError("Could not create benchmark schema"); + } + + if (ArrowArrayInitFromSchema(&array.value, &schema.value, &na_error) != NANOARROW_OK) { + state.SkipWithError("Could not init array from schema"); + } + + if (ArrowArrayStartAppending(&array.value) != NANOARROW_OK) { + state.SkipWithError("Could not start appending to array"); + } + + // TODO: how should we construct this? + for (size_t i = 0; i < array.value.n_children; i++) { + // assumes fixed size primitive layouts for now + struct ArrowBuffer* buffer = ArrowArrayBuffer(array.value.children[i], 1); + if (ArrowBufferAppendFill(buffer, 0, 10000) != NANOARROW_OK) { + state.SkipWithError("Could not append to array"); + } + if (ArrowBufferAppendFill(buffer, 1, 10000) != NANOARROW_OK) { Review Comment: It may be worth having an Arrow IPC file that contains a bigger set of such data, perhaps generated using Arrow C++'s testing facilities or some pyarrow code. Then nanoarrow's IPC reader could get you the values here maintaining the current set of dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
