assignUser commented on code in PR #38176:
URL: https://github.com/apache/arrow/pull/38176#discussion_r1354008015
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -5070,8 +5070,20 @@ endif()
# Azure SDK for C++
function(build_azure_sdk)
+ if(CMAKE_VERSION VERSION_LESS 3.22)
+ # We can't disable installing Azure SDK for C++ by
+ # "set_property(DIRECTORY ${azure_sdk_SOURCE_DIR} PROPERTY
+ # EXCLUDE_FROM_ALL TRUE)" with CMake 3.16.
+ #
+ # At least CMake 3.22 on Ubuntu 22.04 works. So we use 3.22
+ # here. We may be able to use more earlier version here.
+ message(FATAL_ERROR "Building Azure SDK for C++ requires at least CMake
3.22. "
+ "(At least we can't use CMake 3.16)")
+ endif()
message(STATUS "Building Azure SDK for C++ from source")
fetchcontent_declare(azure_sdk
+ # EXCLUDE_FROM_ALL is available since CMake 3.28
+ # EXCLUDE_FROM_ALL TRUE
Review Comment:
iirc you could just leave that there and cmake will ignore it if it doesn't
know it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
