pitrou commented on code in PR #38192: URL: https://github.com/apache/arrow/pull/38192#discussion_r1354851130
########## cpp/thirdparty/flatbuffers/include/flatbuffers/allocator.h: ########## @@ -0,0 +1,78 @@ +/* + * Copyright 2021 Google Inc. All rights reserved. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef FLATBUFFERS_ALLOCATOR_H_ +#define FLATBUFFERS_ALLOCATOR_H_ + +// Move this vendored copy of flatbuffers to a private namespace, +// but continue to access it through the "flatbuffers" alias. +namespace arrow_vendored_private { Review Comment: If we switch to C++17-style `arrow_vendored_private::flatbuffers` it probably reduces the patch size and may make automation more doable as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
