lidavidm commented on code in PR #1181:
URL: https://github.com/apache/arrow-adbc/pull/1181#discussion_r1354872987
##########
c/validation/adbc_validation.cc:
##########
@@ -1507,7 +1507,7 @@ void StatementTest::TestSqlIngestLargeString() {
void StatementTest::TestSqlIngestBinary() {
ASSERT_NO_FATAL_FAILURE(TestSqlIngestType<std::string>(
- NANOARROW_TYPE_BINARY, {std::nullopt, "", "\x00\x01\x02\x04",
"\xFE\xFF"}));
+ NANOARROW_TYPE_BINARY, {std::nullopt, "", "\x01\x02\x03\x04",
"\xFE\xFF"}));
Review Comment:
It was not, but I think we should still test that bytestrings containing
nulls work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
