felipecrv commented on code in PR #35345:
URL: https://github.com/apache/arrow/pull/35345#discussion_r1355427304
##########
cpp/src/arrow/type_traits.cc:
##########
@@ -67,21 +67,23 @@ int RequiredValueAlignmentForBuffer(Type::type type_id, int
buffer_index) {
case Type::BINARY: // Offsets may be cast to int32_t*
case Type::DATE32:
case Type::TIME32:
- case Type::LIST: // Offsets may be cast to int32_t*, data is in child
array
- case Type::MAP: // This is a list array
+ case Type::LIST: // Offsets may be cast to int32_t*, data is in
child array
+ case Type::LIST_VIEW: // Same as LIST
Review Comment:
No need to go into so much detail. Take this to mean that "aligment
requirements of numeric buffers are the same between list and list-views".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
